Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add retries to waitForTransactionReceipt #470

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

jxom
Copy link
Member

@jxom jxom commented May 10, 2023

PR-Codex overview

This PR fixes an issue with waitForTransactionReceipt throwing immediately for slow RPC Providers. It adds a retry mechanism to the function.

Detailed summary

  • Added a retries variable to keep track of the number of retries.
  • If waitForTransactionReceipt fails, it will retry up to 2 times before rejecting the promise.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023

🦋 Changeset detected

Latest commit: 82445d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 9:34pm

@jxom jxom merged commit be9501e into main May 10, 2023
@jxom jxom deleted the jxom/wait-for-txn-retries branch May 10, 2023 21:44
@github-actions github-actions bot mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants